feat(aws-s3-deployment): Cleanup temp directory after sync #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can get filled up and errors out with "no disk space left" if the lambda function is warm
|
Oh that's a nice suggestion - however I would rather switch to an implementation that leverages: with tempfile.TemporaryDirectory() as workdir:
# The stuffThis would guarantee the temporary directory gets cleaned, even if an error is thrown, and that's a little more elegant than writing a What do you think? |
RomainMuller
changed the title
|
@RomainMuller I can add it but it seems redundant -- the code above ensures that directory will exist |
That would then also replace the |
srchase
added
feature-request
rix0rrr
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment lambda function tmp dir can get filled up and errors out with "no disk space left" if it's warm.
Pull Request Checklist
Please check all boxes, including N/A items:
Testing
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.